search

googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

marking event handler as 'passive #940

Closed etomProductions closed 3 years ago

etomProductions commented 4 years ago

Hello,

Is this a solution for this warning please? bridge3.410.0_en.html:91 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

You can find the warning even in your example provided as demo. Sample Page

Thank you,

Kiro705 commented 4 years ago

Hello @etomProductions ,

Can you provide steps for reproducing this error? Or which sample causes the error?

Thank you, Jackson IMA SDK DevRel

etomProductions commented 4 years ago

Hello @Kiro705,

First of all thank you so much for reply to my question and apologize for the delay as I did not got any notification from github and I will look to my email settings.

AS I mentioned above it (was) showing also in your example page as well if you open the console but for some reason not any more. Did you updated the page?

Please advise.

For me I have the error in my own host (private and dont have yet public access.) and I tried it in different hosts with the same result. and the issue was causing was blocking the scrolling behavior while Ad is running.

Thank you, Kind Regards, Tariq

Kiro705 commented 4 years ago

Hello @etomProductions ,

Sorry for the slow reply. Without a way for me to reproduce the issue, it will be difficult to help with a solution.

Are there any specifics you can provide, as to types of devices/browsers where the error occurs. If it specific to certain ad types?

More obviously, if your code is adding any event listeners to the 'touchmove' event, I would look there to resolve the issue.