googleads / videojs-ima

IMA SDK Plugin for Video.js
Apache License 2.0
450 stars 284 forks source link

Add Open Measurement APIs #992

Closed Kiro705 closed 3 years ago

Kiro705 commented 3 years ago

Currently, there are not methods to follow the IMA's Open Measurement guide. These should be added.

amusakhan2016 commented 3 years ago

Hello Kiro,

When we can expect a fix for the issue?

Thanks,

Kiro705 commented 3 years ago

Hello @amusakhan2016 ,

I have https://github.com/googleads/videojs-ima/pull/994 which should add the APIs for the OMSDK. I will work on publishing a new version soon with these changes.

Kiro705 commented 3 years ago

Support for the OMSDK has been added in v1.11.0 of the plugin.

Please let me know if you have any follow up questions.

moeednisardms commented 3 years ago

Hi Kiro,

Thank you for the updated version of the plugin.

I have updated the files and enabled the settings as shown in the screenshot http://prntscr.com/12r6nww but still the access is limited in the request.

Below is the screenshot of the errors we're getting in the console. http://prntscr.com/12r6vq1

Could you please advise?

Thanks

Kiro705 commented 3 years ago

Hello @moeednisardms ,

You should call player.ima(imaOptions); early on in your initiation of the page. From the snippet I cannot confirm this is being done.

In addition, your regex '^moatads\\.com.*$' may need to be '^moatads\\.com/.*$'with the addition of that forward slash.

Let me know if either of those suggestions helps debug the issue.

Thank you, Jackson IMA SDK Team

moeednisardms commented 3 years ago

Hi @Kiro705,

We have both the options in place http://prntscr.com/12zrnlk but still having limited access in the request. http://prntscr.com/12zrq1z

Thanks

Kiro705 commented 3 years ago

Hello @moeednisardms ,

If you implement the omsdk guide with the IMA simple example, do you still see limited access? If you could test this, it would help me to determine if the issue is the VideoJS-IMA plugin or IMA in general.

Let me know if this is or is not possible for you.

Thank you, Jackson IMA SDK Team

moeednisardms commented 3 years ago

Hi @Kiro705,

OK. I will try to implement it and let you know.

thanks

moeednisardms commented 3 years ago

HI @Kiro705,

I have implemented the OM SDK guide step by step using IMA simple example and still seeing limited access. It seems that the issue is with IMA.

Thanks

moeednisardms commented 3 years ago

Hi @Kiro705,

The issue has been fixed. It was the issue with RegEx. We checked both IMA simple example and VideoJS example as well and now we're seeing that the MOAT script has full access.

Thank you for your support.

Kiro705 commented 3 years ago

Hi @moeednisardms ,

Thank you for the follow up. I'm glad you were able to resolve the issue.

If possible could you share the fix here? It may be helpful to others who come across a similar issue. Feel free to not use your specific regex, but something like the regex found in our OMSDK guide.

Thank you, Jackson IMA SDK team

moeednisardms commented 3 years ago

Hi @Kiro705,

The below regex has fixed the issue for us. new RegExp('[.+\.]examplevendor1\.com.$')

Thanks

moeednisardms commented 1 year ago

Hi Kiro,

I hope all is well.

We noticed that OMID implementation has been updated. could you please let us know how to pass the OMID now? below is the previous implementation we had

featureFlags:{'enableOmidBeta': true}, omidMode:{ FULL: [ new RegExp('[.+\.]moatads\.com.$') ] },

we updated the source files and passing the omidVendorAccess as below, however the access to MOAT is still limited. omidVendorAccess: {"MOAT":'FULL'},

Test page URL: https://dmscg.com/tech/video/jsplayer/index.html play the video, and search for OMSDK in the network tab. screenshot: https://prnt.sc/JUCRtJI9dRVY

Thanks