Fix: Keep order of metrics consistent

googleanalytics / autotrack

Automatic and enhanced Google Analytics tracking for common user interactions on the web.

Other

4.92k stars 560 forks source link

Fix: Keep order of metrics consistent #228

Closed localheinz closed 4 years ago

localheinz commented 6 years ago

This PR

[x] keeps the order of metrics consistent

💁‍♂️ As of the moment, the documentation mentions the calculated metrics in the order

Avg. Page Visible Time (per Page)
Avg. Page Visible Time (per Session)

screen shot 2018-05-16 at 21 09 19

but then provides the formulas in reverse order

Avg. Page Visible Time (per Session)
Avg. Page Visible Time (per Page)

screen shot 2018-05-16 at 21 09 28

To reduce the confusion (and possibly, mistakes when people skim the documentation), I propose to reserve the order of the formulas.

philipwalton commented 6 years ago

Hmmm, I see your point, and I think making everything consistent would be good. The only thing is the paragraph after the one in your screen shot mentions session dimensions before page dimensions.

Would you mind also rewording that paragraph, so everything is in the same order?

localheinz commented 6 years ago

@philipwalton

Would you mind also rewording that paragraph, so everything is in the same order?

Done!