googleapis / api-linter

A linter for APIs defined in protocol buffers.
https://linter.aip.dev/
Apache License 2.0
583 stars 142 forks source link

feat: undelete should not be required for declarative-friendly interfaces #1304

Closed andrei-scripniciuc closed 9 months ago

andrei-scripniciuc commented 9 months ago

according to https://google.aip.dev/164#declarative-friendly-resources:

Soft-deletable resources have a poorer experience than hard-deleted resources in declarative clients

this contradicts the requirement that declarative-friendly interfaces implement soft-delete.

conventional-commit-lint-gcf[bot] commented 9 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

bgrant0607 commented 9 months ago

There are more occurrences: https://github.com/search?q=repo%3Agoogleapis%2Fapi-linter%20declarativeFriendlyRequired&type=code

bgrant0607 commented 9 months ago

Ok, this is just removing the check from 164, not from everywhere.