googleapis / api-linter

A linter for APIs defined in protocol buffers.
https://linter.aip.dev/
Apache License 2.0
558 stars 137 forks source link

fix(AIP-121): recognize standard list revisions #1347

Closed noahdietz closed 4 months ago

noahdietz commented 4 months ago

Since AIP-162 recommends Revisions being a proper resource collection, it will also be checked for standard List and Get RPCs as per AIP-121. However, the rule enforcing the Standard List requirement was ignoring list revision methods explicitly. This brings List{Resource}Revisions into consideration for that rule.

Fixes internal bug

noahdietz commented 4 months ago

May be overtaken by https://github.com/googleapis/api-linter/pull/1348

noahdietz commented 4 months ago

This should be necessary anymore since #1348 brings "new" list revisions methods into scope of Standard List.