googleapis / api-linter

A linter for APIs defined in protocol buffers.
https://linter.aip.dev/
Apache License 2.0
600 stars 144 forks source link

fix(AIP-133): use resource field in signature suggestion #1439

Closed noahdietz closed 1 month ago

noahdietz commented 1 month ago

Fix the way that the expected resource field name is derived for Standard Create method_signatures. When the resource field in the request message uses a name that doesn't exactly mirror the resource type/RPC name, the previous logic suggested a method_signature including a field that didn't exist. Since this rule isn't supposed to also govern the field's name itself, just roll with it.

Also fixes the way the output type is evaluated for the resource parent/no-parent case when the response type is an Operation.

Moves the LRO test to its own case.

Addresses internal feedback http://b/372508475