googleapis / artman

Artifact Manager, a build and packaging tool for Google API client libraries.
Apache License 2.0
134 stars 86 forks source link

Update gapic-generator hash and Java resource name plugin #825

Closed yihanzhen closed 4 years ago

yihanzhen commented 4 years ago

gapic-generator:

resource name plugin

also whitelist Asset to unblock releasing artman.

yihanzhen commented 4 years ago

Looking at golden test...

alexander-fenster commented 4 years ago

Golden test is basically just a list of filenames that gets compared to the output. Seems like Python has changed noxfile.py to nox.py? It's in https://github.com/googleapis/gapic-generator/pull/3156.

yihanzhen commented 4 years ago

@alexander-fenster done!

alexander-fenster commented 4 years ago

Isn't it cool to release artman in your last day in the team @hzyi-google ? :)

yihanzhen commented 4 years ago

Hahaha and I even looked into the golden test directory for the first time :)