googleapis / cloud-profiler-nodejs

Node.js library for Google Cloud Profiler. Continuous CPU and heap profiling to improve performance and reduce costs.
https://cloud.google.com/profiler/
Apache License 2.0
68 stars 35 forks source link

chore!: upgrade to Node 14 #891

Closed gcf-owl-bot[bot] closed 1 year ago

gcf-owl-bot[bot] commented 1 year ago

Co-authored-by: Jeffrey Rennie rennie@google.com

Source-Link: https://github.com/googleapis/synthtool/commit/1a2431537d603e95b4b32317fb494542f75a2165 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 25.00% and project coverage change: +0.63% :tada:

Comparison is base (1d4f79b) 68.87% compared to head (9f6bf0f) 69.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #891 +/- ## ========================================== + Coverage 68.87% 69.50% +0.63% ========================================== Files 7 7 Lines 1253 1256 +3 Branches 58 48 -10 ========================================== + Hits 863 873 +10 + Misses 389 382 -7 Partials 1 1 ``` | [Files Changed](https://app.codecov.io/gh/googleapis/cloud-profiler-nodejs/pull/891?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=googleapis) | Coverage Δ | | |---|---|---| | [src/profiler.ts](https://app.codecov.io/gh/googleapis/cloud-profiler-nodejs/pull/891?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=googleapis#diff-c3JjL3Byb2ZpbGVyLnRz) | `72.83% <25.00%> (+0.65%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/googleapis/cloud-profiler-nodejs/pull/891/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=googleapis)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sofisl commented 1 year ago

@aabmass I can't seem to get the Kokoro integration test to pass. Can you take a look?

aabmass commented 1 year ago

I'll just try re-running them, these are sometimes flaky.