search

googleapis / cloud-profiler-nodejs

Node.js library for Google Cloud Profiler. Continuous CPU and heap profiling to improve performance and reduce costs.
https://cloud.google.com/profiler/
Apache License 2.0
68 stars 35 forks source link

chore: add node 20 to github actions matrix #920

Closed aabmass closed 9 months ago

generated-files-bot[bot] commented 9 months ago

Warning: This pull request is touching the following templated files:

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c057bf1) 69.50% compared to head (8c45061) 69.65%. Report is 4 commits behind head on main.

Files Patch % Lines
src/logger.ts 84.61% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #920 +/- ## ========================================== + Coverage 69.50% 69.65% +0.14% ========================================== Files 7 7 Lines 1256 1262 +6 Branches 48 49 +1 ========================================== + Hits 873 879 +6 Misses 382 382 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aabmass commented 9 months ago

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

See this note https://github.com/googleapis/cloud-profiler-nodejs/blob/8eb21a2004101d68df27e91c2c0c932551dbd33d/.github/workflows/ci.yaml#L1-L6

That linked file supports node 20 as well