Update Restify Plugin to support Restify versions 9-11

googleapis / cloud-trace-nodejs

Node.js agent for Cloud Trace: automatically gather latency data about your application

https://cloud.google.com/trace/

Apache License 2.0

278 stars 98 forks source link

Update Restify Plugin to support Restify versions 9-11 #1488

Closed 6utt3rfly closed 1 year ago

6utt3rfly commented 1 year ago

The existing Restify plugin is defined to only operate up to version 8. It was last updated in Apr 2020 from #1250 . The restify changelog has newer, recent releases: 9.0.0 2022-11-05 (drops node <8) 10.0.0 2022-11-29 (adds support for node 18) 11.0.0 2023-01-17

Is it possible to upgrade the restify plugin version range to enable support for the new versions - especially so that node 18 can be supported with restify and this plugin?

punya commented 1 year ago

Hi @6utt3rfly. As the README describes, cloud-trace-nodejs is in maintenance mode. That means we'll continue to patch security vulnerabilities, but we won't work on new features (including supporting new major versions of libraries).

We will, however, consider merging contributed PRs. I see that you've already created #1489 - please take a look at the test failures.