search

googleapis / disco-to-proto3-converter

Apache License 2.0
11 stars 11 forks source link

fix: add a missing break statement #100

Closed munahaf closed 3 weeks ago

munahaf commented 1 year ago

In file: DocumentToProtoConverter.java, class: DocumentToProtoConverter, the body of a method schemaToField has a case statement that is not terminated by a break. I suggested that a break statement be introduced to terminate the case statement.

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

vchudnov-g commented 3 weeks ago

Done in #131.