search

googleapis / env-tests-logging

Apache License 2.0
3 stars 6 forks source link

fix: Change snippet to close logging channel #66

Closed minherz closed 2 years ago

minherz commented 3 years ago

Change code in Snippets.simpleLog() to call Logging.close() implicitly Propogate exception thrown by close() to the caller wrapped in InvocationTargetException Resolve warnings in Snippets and DeployableApplication classes.

Fixes googleapis/java-logging#676

minherz commented 3 years ago

@daniel-sanche you will have to trigger Kokoro test. It does not run automatically because it is my first submission.

daniel-sanche commented 3 years ago

@daniel-sanche you will have to trigger Kokoro test. It does not run automatically because it is my first submission.

Actually, there are no CI tests on this repo. You'll have to make another PR updating the Java repo's submodule to use this commit, and the tests will run there. (I want to look into running tests on all languages here as well, but that may be difficult)

I ran the tests manually with envctl and they looked good to me though! Thanks for finding the fix!