search

googleapis / env-tests-logging

Apache License 2.0
3 stars 6 forks source link

fix: uuid generation with different python versions #90

Closed daniel-sanche closed 2 years ago

daniel-sanche commented 2 years ago

envctl was previously using python to generate a uuid value meant to create a unique temporary directory. This was causing issues on the go tests, which don't have a python executable (using python3 instead)

This fix guards against this issue by:

  1. not creating a uuid if it was already generated as an environment variable
  2. adding ENV_TEST_PY_VERSION to the python version if set. This was already used as a solution for different Python versions, so if it is already set, it can fix this problen
conventional-commit-lint-gcf[bot] commented 2 years ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/