feat: support wrapper types for autopagination - Githubissues

googleapis / gapic-generator-go

Generate Go API client libraries from Protocol Buffers.

Apache License 2.0

252 stars 48 forks source link

feat: support wrapper types for autopagination #1541

Closed shollyman closed 2 months ago

shollyman commented 4 months ago

This PR widens support for autopagination in the go gapic generator. Changes:

enable autopaging detection to include wrapper types in the heuristic
allowlist control for enabling wrapper support based on proto package name
templating changes for support
augment the autopagination denylist to avoid generating a paginatinated signature for an additional API/method

Things still outstanding:

Testing depth: this validates detection, but doesn't expand goldens testing to use a wrapper-based list RPC. That said, we only expect the single service to leverage this, and I have verified the generated client out of band.

shollyman commented 2 months ago

looks like the showcase testing in integration testing is broken in general, not due to this PR: https://github.com/googleapis/gapic-generator-go/pull/1552