search

googleapis / gapic-generator-python

Generate Python API client libraries from Protocol Buffers.
Apache License 2.0
122 stars 69 forks source link

Catch warnings in flattened tests for deprecated fields in gapic-generator-python #1938

Open mukund-ananthu opened 9 months ago

mukund-ananthu commented 9 months ago
  1. Currently, the warnings are bubbling up and blocking submission of PRs like: https://github.com/googleapis/python-pubsub/pull/1064
  2. A temporary silencing of the warning is being added in https://github.com/googleapis/python-pubsub/blob/main/pytest.ini as part of https://github.com/googleapis/python-pubsub/pull/1066. This silencing of warning is to be removed once warnings are no longer bubbled up from the flattened tests.
mukund-ananthu commented 9 months ago

cc: @parthea

mukund-ananthu commented 9 months ago

Fixed as part of https://github.com/googleapis/python-pubsub/pull/1066

parthea commented 9 months ago

@mukund-ananthu Please could you file an issue in gapic-generator-python for the long term fix to improve the generated unit tests ? The underlying issue is that deprecation warnings should not bubble up in flattened tests for deprecated fields.

mukund-ananthu commented 9 months ago

Please could you file an issue in gapic-generator-python for the long term fix to improve the generated unit tests

@parthea Sure. Created https://github.com/googleapis/gapic-generator-python/issues/1937