search

googleapis / gapic-generator

Tools for generating API client libraries from API Service Configuration descriptions.
Apache License 2.0
303 stars 129 forks source link

fix: PHP Use a deterministic ordering for rest placeholders #3333

Closed chrisdunelm closed 3 years ago

chrisdunelm commented 3 years ago

Deterministic outputs are required for automated testing of the micro-generator when comparing outputs between generators

codecov[bot] commented 3 years ago

Codecov Report

Merging #3333 (d21da72) into master (1d7141f) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3333   +/-   ##
=========================================
  Coverage     87.13%   87.14%           
  Complexity     6120     6120           
=========================================
  Files           495      495           
  Lines         24174    24176    +2     
  Branches       2638     2638           
=========================================
+ Hits          21065    21067    +2     
  Misses         2242     2242           
  Partials        867      867
Impacted Files Coverage Δ Complexity Δ
...en/transformer/php/PhpGapicSurfaceTransformer.java 93.06% <100.00%> (+0.04%) 46.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d7141f...d21da72. Read the comment docs.

chrisdunelm commented 3 years ago

Thanks @bshaffer :)

chrisdunelm commented 3 years ago

@noahdietz @miraleung if one of you could possibly review this (tiny!) PR, that'd be great :) I think it needs an actools reviewer before I can merge... Thank you!