search

googleapis / gapic-generator

Tools for generating API client libraries from API Service Configuration descriptions.
Apache License 2.0
305 stars 129 forks source link

PHP gapic generator is not deterministic #3338

Closed SurferJeffAtGoogle closed 3 years ago

SurferJeffAtGoogle commented 3 years ago

It generates different output for the same input on consecutive runs.

Example: https://github.com/googleapis/googleapis-gen/commit/a7dd37b1d69d4a274613cff07dd58eb1aefac1e4

Looks like chunks get generated in a different order depending on no variable I can observe. image

This is fatal to all our code-generating automation: autosynth, bazel-bot, owl-bot, etc.

SurferJeffAtGoogle commented 3 years ago

The diff is for RecommendationService.php.

SurferJeffAtGoogle commented 3 years ago

I haven't seen it in about 3 weeks. I'll re-open if I see it again.