search

googleapis / gax-java

This library has moved to https://github.com/googleapis/sdk-platform-java/tree/main/gax-java.
https://github.com/googleapis/gapic-generator-java/tree/main/gax-java
BSD 3-Clause "New" or "Revised" License
162 stars 119 forks source link

fix: [Approach 2] Watchdog does not shut down executor on client closing if the executor is provided by ExecutorProvider. #1883

Closed blakeli0 closed 1 year ago

blakeli0 commented 1 year ago

This approach has fewer code changes, but it makes shouldAutoClose not the only source of truth for us to decide should we close the Watchdog(and the executor) or not, it is now implicitly decided by shouldAutoClose and needExecutor in ClientContext. It may cause some confusion if a customer decides to implement their own WatchdogProvider.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

blakeli0 commented 1 year ago

Closing in favor of https://github.com/googleapis/gax-java/pull/1890 and https://github.com/googleapis/gax-java/pull/1884