search

googleapis / gax-java

This library has moved to https://github.com/googleapis/sdk-platform-java/tree/main/gax-java.
https://github.com/googleapis/gapic-generator-java/tree/main/gax-java
BSD 3-Clause "New" or "Revised" License
162 stars 119 forks source link

feat: add an option to enable DirectPath xDS #1968

Closed mohanli-ml closed 1 year ago

mohanli-ml commented 1 year ago

Currently DirectPath xDS is enabled by using env. We want to also provide an option for this.

Go PR: https://github.com/googleapis/google-api-go-client/pull/1942

@veblush

mohanli-ml commented 1 year ago

@suztomo Hi Tomo, can you review this PR? Thanks!

suztomo commented 1 year ago

I assigned Blake.

blakeli0 commented 1 year ago

@mohanli-ml, we recently moved this repo to gapic-generator-java, can you please close this PR and open a new PR in gapic-generator-java?

suztomo commented 1 year ago

(I didn't notice this PR was created in an old repo. Thanks.)

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

25.0% 25.0% Coverage
0.0% 0.0% Duplication

mohanli-ml commented 1 year ago

@blakeli0 The new PR: https://github.com/googleapis/gapic-generator-java/pull/1643. (I did not know the repo is moved. Thanks!)