search

googleapis / gax-java

This library has moved to https://github.com/googleapis/sdk-platform-java/tree/main/gax-java.
https://github.com/googleapis/gapic-generator-java/tree/main/gax-java
BSD 3-Clause "New" or "Revised" License
162 stars 119 forks source link

fix: Allow quota project to be used in combination with null credentials #1971

Closed irock closed 1 year ago

irock commented 1 year ago

Credentials may be null, e.g. when connecting to an emulator. This fix makes it possible to use null credentials in combination with setting quota project id, something that may be useful in testing.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

burkedavison commented 1 year ago

Hello @irock - thank you for your contribution!

Active development for this project has moved to https://github.com/googleapis/sdk-platform-java/tree/main/gax-java

Please reopen your PR in the new location to have it reviewed by the appropriate people.

Edit: When doing so, please also create an issue in the repo associated with your change.

irock commented 1 year ago

Thanks for letting me know!

Opened issue https://github.com/googleapis/sdk-platform-java/issues/1687 and PR https://github.com/googleapis/sdk-platform-java/pull/1688.