googleapis / gax-nodejs

Google API Extensions for Node.js
Apache License 2.0
112 stars 81 forks source link

getIamPolicy for KMS KeyManagementServiceClient is erroring with Syntax Error: Unexpected token < in JSON at position 0 , when using fallback REST #1462

Open sirohiwebdev opened 1 year ago

sirohiwebdev commented 1 year ago

1) Is this a client library issue or a product issue? Yes it is a client library issue, the definition for getIamPolicy method in iam_services.json mentions POST call whether the actual call is GET

2) Did someone already solve this? Could not find any solution or issues created for the same.

3) Do you have a support contract? No

Environment details

Steps to reproduce

  1. Call the following method for KMS
    
    import * as kms from "@google-cloud/kms";
    import { google } from "@google-cloud/iap/build/protos/protos";
    import GetIamPolicyRequest = google.iam.v1.GetIamPolicyRequest;

const keyManagementServiceClient = new kms.KeyManagementServiceClient({ credentials: { client_email: "user@project-id.iam.gserviceaccount.com", private_key:"very-long-private-key", }, projectId: "project-id", fallback: "rest", });

const req = new GetIamPolicyRequest({ resource: "projects/project-id/locations/global/keyRings/qflow", }); keyManagementServiceClient .getIamPolicy(req) .then(console.log) .catch(console.error);


2. It is using the POST method to hit the API
Output (Before)
![image](https://github.com/googleapis/gax-nodejs/assets/32898073/629ea27f-dbbc-4a09-a455-ed01c053ad80)

3. After making a change to the following [file ](https://github.com/googleapis/gax-
nodejs/blob/main/protos/iam_service.json#L43,L49)and replacing `post` with `get`  issue seems to be resolved. 

Changes 

![image](https://github.com/googleapis/gax-nodejs/assets/32898073/1512f9c5-1702-4bc0-88af-b6fe94189d70)

Output (After)
![image](https://github.com/googleapis/gax-nodejs/assets/32898073/c16fe8d0-875e-47dc-8214-6131527f0730)

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!
sirohiwebdev commented 10 months ago

Hi @alexander-fenster Eagerly waiting for your response.