search

googleapis / gax-nodejs

Google API Extensions for Node.js
Apache License 2.0
113 stars 83 forks source link

gaxStreamingRetries retries when retryCodes is an empty array #1577

Closed leahecole closed 3 months ago

leahecole commented 3 months ago

The default retry strategy for server streaming retries does not consider the very common case that retryCodes is an empty array - in this case, we should not retry.

leahecole commented 3 months ago

This may still be an issue for normalCalls - I'm working on investigating it after internal bug 330914422 was opened. There is a test that's supposed to check for it that was passing, and I need to investigate more to understand it all better.

leahecole commented 3 months ago

I think that this is WAI for normal calls but will reopen if necessary