search

googleapis / gax-nodejs

Google API Extensions for Node.js
Apache License 2.0
113 stars 83 forks source link

fix: don't retry server streaming calls if retryCodes is the empty array #1578

Closed leahecole closed 3 months ago

leahecole commented 3 months ago

Fixes #1577 - adds logic that checks for retrycodes being empty which is very common in client configs. Enables us to turn this feature on in Spanner (Spanner tests broke previously)

cc @galz10 in case you're curious

leahecole commented 3 months ago

sorry, I hadn't rebased/merged this repo in awhile and didn't realize it was going to have an ugly history - I'm working on cleaning it up

leahecole commented 3 months ago

If you want, I can try to clean up the history more, but I've gotten it to the point where the PR only touches the files it needs to and I figure it's going to be squashed when its merged, so I'm going to stop for now