Which value to use for denoting error code in "RetrySettings"?

[lezhnev74]

Hello! I am trying to use the built-in feature of retrying API requests as explained in here: src/RetrySettings.php. However it is not clear what value to pass in retryableCodes.

There are two options:

• pass the string value of \Google\ApiCore\ApiStatus constants like ApiStatus::DEADLINE_EXCEEDED

  • this variant described in the comments here: RetrySettings.php

• pass the integer value of \Google\Rpc\Code constants like Code::DEADLINE_EXCEEDED

  • this variant is used in the tests here: RetrySettingsTest.php

What type I should use?

[dwsupplee]

Hey there @lezhnev74 - this is a great question. You'll want to use the constants with string values (ApiStatus::DEADLINE_EXCEEDED), as that is what is keyed in to being used by the RetryMiddleware.

I can definitely see where the confusion came about due to the tests and the annotated return type on RetrySettings::getRetryableCodes.

@jdpedrie would you have a few cycles to help update the return type/tests?