search

googleapis / gax-php

Google API Extensions for PHP
http://googleapis.github.io/gax-php/
BSD 3-Clause "New" or "Revised" License
237 stars 52 forks source link

chore: Improved developer experience by adding development commands to composer.json scripts #559

Closed norberttech closed 6 months ago

norberttech commented 6 months ago

This is a bit opinionated approach so feel free to close that proposal. From my experience simplifying the developer experience increases the number of valuable contributions. I believe that exposing development tools through composer scripts makes devs' work easier since there is only one place they need to look to understand how to work with that repo.

bshaffer commented 6 months ago

Now that we have these commands, we can update our workflow file to match!

norberttech commented 6 months ago

Speaking about workflow files, what are your thoughts about running all the tools (coding standards / static analysis) on the lowest supported version of PHP with the latest versions of dependencies?

So let's say this lib supports PHP: [8.0, 8.1, 8.2], I would change static analysis and coding standards to run on 8.0.

I ran into some discrepancies in the past between CI and people's local development environments. After that, I made a rule for all my repos that development should always happen on the lowest supported version of PHP to reduce the possibility of using unsupported features or getting false positive results from static analysis.

Edit: Tests would stay untouched as they should be executed at the whole matrix with the lowest/highest dependencies.