search

googleapis / gax-php

Google API Extensions for PHP
http://googleapis.github.io/gax-php/
BSD 3-Clause "New" or "Revised" License
237 stars 52 forks source link

feat: support V2 OperationsClient in OperationResponse #564

Closed ajupazhamayil closed 6 months ago

ajupazhamayil commented 6 months ago 
setter

I see the request objects that we are referring in the OperationsClient does not have any arguments other than the name. Example, see the DeleteOperationRequest. I am unable to understand how these extra attributes are being set to those request methods!

ajupazhamayil commented 6 months ago

Are they(Compute or similar) using a different client like ZoneOperationsClient?

Refer: https://github.com/googleapis/google-cloud-php-compute/blob/db27fb2832731a827957c3adbaeb5983c1202a9b/src/V1/Client/InstanceSettingsServiceClient.php#L97

ajupazhamayil commented 6 months ago

Please note tests are not yet added, working on it currently