feat: support new surface operations clients - Githubissues

googleapis / gax-php

Google API Extensions for PHP

http://googleapis.github.io/gax-php/

BSD 3-Clause "New" or "Revised" License

234 stars 50 forks source link

feat: support new surface operations clients #569

Closed bshaffer closed 3 months ago

bshaffer commented 4 months ago

See https://github.com/googleapis/gapic-generator-php/pull/712. Adds 3 options to the OperationsResponse class:

$getOperationRequest
$cancelOperationRequest
$deleteOperationRequest

These are used to form the request to the V2 Operations client

Pros

Does not use ReflectionMethod to determine first argument Request class, which is a hack

Cons

Requires a change to the existing longRunning descriptors

Alternatives Considered We could add a ReflectionMethod to determine the request class of the Operation methods (see https://github.com/googleapis/gax-php/pull/570)