feat: add support for new surface operations client

googleapis / gax-php

Google API Extensions for PHP

http://googleapis.github.io/gax-php/

BSD 3-Clause "New" or "Revised" License

237 stars 52 forks source link

feat: add support for new surface operations client #571

Closed bshaffer closed 5 months ago

bshaffer commented 5 months ago

add a new method createNewSurfaceOperationsClient (private) while we migrate the previous classes over.

This is because we accidentally shipped GA "new surface" clients which use the previous surface's operations clients. We don't want to break GA clients, so we can only change the client classes for clients which are NEW_SURFACE_ONLY (e.g. they do not contain legacy clients).

bshaffer commented 5 months ago

I think this direction is not a good idea, and it inflates an already-inflated GapicClientTrait.

Better to generate the logic directly in the GAPIC client.

bshaffer commented 5 months ago

Closing in favor of https://github.com/googleapis/gapic-generator-php/pull/714