googleapis / gax-php

Google API Extensions for PHP
http://googleapis.github.io/gax-php/
BSD 3-Clause "New" or "Revised" License
237 stars 52 forks source link

feat: Add support for to use a object with a union type #580

Open Hectorhammett opened 2 months ago

bshaffer commented 1 month ago

@Hectorhammett One thought on this - if we are unhappy with the ClientOptions interface, as we haven't exposed this class directly for use (nothing in our libraries accept OR return this class), if we want to make a change to it, now's the time.

I would suggest, just for safety, that we mark any changing methods as @deprecated for a month or so before doing this, just to be safe. But if we want to turn these into POPOs (which I think is a great idea), now's the time.

EDIT: Honorable mention here is to also move $quotaProject outside the credentials wrapper