Fix packaging setup - Githubissues

googleapis / gax-python

Google API Extensions for Python

http://gax-python.readthedocs.org/en/latest/

BSD 3-Clause "New" or "Revised" License

25 stars 13 forks source link

Fix packaging setup #174

Closed theacodes closed 7 years ago

theacodes commented 7 years ago

Don't include tests in the binary (wheel) distribution.
Include tests in the source distribution.
Remove (seemingly?) unneeded package_dir.
Use io.open over open for proper encoding.

theacodes commented 7 years ago

@dhermes recently objected to sending tests to users in the source distribution. What is the final position on this?

Distributing tests in the source distribution (sdist) is preferable as it allows downstream packagers to run tests. Distributing tests in the binary distribution (wheel) is bad because it ends up being installed in site-packages.

dhermes commented 7 years ago

I defer to @jonparrott on such things.