search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Google::Longrunning::OperationsClient prints warnings #102

Closed blowmage closed 6 years ago

blowmage commented 6 years ago

The generated GAPIC code that exposes operations endpoints prints the following warning, with no way to avoid it.

`service_path` and `port` parameters are deprecated and will be removed

This is because the generated GAPIC code creates an Google::Longrunning::OperationsClient with the service_path argument, causing the warning.

geigerj commented 6 years ago

GAX 0.9.2, which removes this warning, has been released. Long term fix to follow the recommended LRO pattern is tracked as https://github.com/googleapis/toolkit/issues/1686.

blowmage commented 6 years ago

I'm seeing this warning when using google-gax 0.9.2, and only when an OperationsClient is being used. I'll investigate further.

blowmage commented 6 years ago

Oops, my mistake. I was running on an older branch that was missing the fixes in GoogleCloudPlatform/google-cloud-ruby#1824. Running on that code I am no longer seeing the warnings. I've even downloaded and inspected the gems from RubyGems to make sure the warning is gone. I believe this can be closed again. :)

geigerj commented 6 years ago

Good to hear!