search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

GaxError presents BadStatus values #104

Closed blowmage closed 6 years ago

blowmage commented 6 years ago

This PR relays the underlying BadStatus values code, details, and metadata without resorting to dynamic hackery using method_missing. If the underlying error object does not have values, or is not a BadStatus, nil is returned.

[refs GoogleCloudPlatform/google-cloud-ruby#1791] [refs GoogleCloudPlatform/google-cloud-ruby#1825]

codecov-io commented 6 years ago

Codecov Report

Merging #104 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   99.35%   99.44%   +0.08%     
==========================================
  Files          18       19       +1     
  Lines        1708     1788      +80     
==========================================
+ Hits         1697     1778      +81     
+ Misses         11       10       -1
Impacted Files Coverage Δ
lib/google/gax/errors.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/error_spec.rb 100% <100%> (ø)
lib/google/gax/grpc.rb 100% <0%> (+2.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e9e15f...70470c0. Read the comment docs.

blowmage commented 6 years ago

Build is fixed. Thank you for your patience.