search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Allow operations client to be subclassed #109

Closed geigerj closed 6 years ago

geigerj commented 6 years ago

Note: this is hand-edited for now to preserve compatibility with older GAPIC clients that set the service address through the ctor. We will refresh the LRO codegen entirely for the 1.0 release.

codecov-io commented 6 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          19       19           
  Lines        1809     1809           
=======================================
  Hits         1799     1799           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c0df7a...16897cd. Read the comment docs.

geigerj commented 6 years ago

@landrito Could you take a look at this one, too? It's required for https://github.com/googleapis/toolkit/pull/1702.