Investigate removing some of proto coercion logic

googleapis / gax-ruby

Google API Extensions for Ruby

https://rubygems.org/gems/google-gax

BSD 3-Clause "New" or "Revised" License

20 stars 22 forks source link

Investigate removing some of proto coercion logic #110

Closed geigerj closed 5 years ago

geigerj commented 6 years ago

What

Investigate if protobuf's coercion is safe (i.e., has the same behavior as GAX's). In cases where it is, consider simplifying GAX hash-to-proto coercion logic by removing duplicated functionality.

Why

A GAX utility currently coerces hashes to protobuf messages. As of 3.5.0, the protobuf runtime handles at least some of these cases (see https://github.com/google/protobuf/pull/3627/).

cc: @landrito

Updates https://github.com/google/protobuf/issues/3120.

lukesneeringer commented 5 years ago

Still under consideration; low priority. (Replying here to bring the issue back into compliance.)

jbolinger commented 5 years ago

There are no plans for this so I'm going to close this until a need arises.