search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Create Errors subclasses analogous to google-cloud-core #112

Closed geigerj closed 6 years ago

geigerj commented 6 years ago

This change allows GAX to raise more specific subclasses of GaxError depending on the actual status of the call when the error is raised.

Fixes #100.

codecov-io commented 6 years ago

Codecov Report

Merging #112 into master will increase coverage by 0.02%. The diff coverage is 98.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   99.45%   99.48%   +0.02%     
==========================================
  Files          19       19              
  Lines        1846     1925      +79     
==========================================
+ Hits         1836     1915      +79     
  Misses         10       10
Impacted Files Coverage Δ
spec/google/gax/api_callable_spec.rb 98.11% <100%> (ø) :arrow_up:
lib/google/gax/errors.rb 100% <100%> (ø) :arrow_up:
lib/google/gax/path_template.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/bundling_spec.rb 99.69% <100%> (ø) :arrow_up:
lib/google/gax/grpc.rb 100% <100%> (ø) :arrow_up:
lib/google/gax/api_callable.rb 98.34% <100%> (+0.01%) :arrow_up:
lib/google/gax/operation.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/error_spec.rb 100% <100%> (ø) :arrow_up:
lib/google/gax/util.rb 97.72% <50%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3e5b8c...e17e5a4. Read the comment docs.