googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Custom exception mapping #123

Closed jbolinger closed 6 years ago

jbolinger commented 6 years ago

Add ability for clients to completely swap out errors with custom error types. Does not change existing functionality for wrapping specified errors with GaxError types.

codecov-io commented 6 years ago

Codecov Report

Merging #123 into master will decrease coverage by 0.19%. The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #123     +/-   ##
=========================================
- Coverage   99.54%   99.35%   -0.2%     
=========================================
  Files          19       19             
  Lines        1991     2014     +23     
=========================================
+ Hits         1982     2001     +19     
- Misses          9       13      +4
Impacted Files Coverage Δ
lib/google/gax/api_callable.rb 97.72% <85.71%> (-0.72%) :arrow_down:
spec/google/gax/api_callable_spec.rb 97.81% <89.47%> (-0.63%) :arrow_down:
spec/google/gax/bundling_spec.rb 99.69% <0%> (-0.31%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be70b17...e023cb1. Read the comment docs.