search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Add interceptor support #127

Closed jbolinger closed 6 years ago

jbolinger commented 6 years ago

This change exposes gRPC interceptors at stub creation time.

@landrito for the corresponding generator change could we follow what you did for python? What would the Ruby code look like to add an interceptor to a client?

[will squash all the junk commits]

codecov-io commented 6 years ago

Codecov Report

Merging #127 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   99.35%   99.35%   +<.01%     
==========================================
  Files          19       19              
  Lines        2014     2029      +15     
==========================================
+ Hits         2001     2016      +15     
  Misses         13       13
Impacted Files Coverage Δ
spec/google/gax/grpc_spec.rb 100% <100%> (ø) :arrow_up:
lib/google/gax/grpc.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed62589...29007bb. Read the comment docs.

jbolinger commented 6 years ago

Updated (also added channel_override since it was missing too).