search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Update construct_settings for config_overrides #13

Closed jmuk closed 8 years ago

jmuk commented 8 years ago

For issue #5, this allows overriding configs in the same format as the default config.

codecov-io commented 8 years ago

Current coverage is 94.88%

Merging #13 into master will increase coverage by 0.31%

@@             master        #13   diff @@
==========================================
  Files             9          9          
  Lines           588        625    +37   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            556        593    +37   
  Misses           32         32          
  Partials          0          0

Powered by Codecov. Last updated by 9734894...49c8caf

geigerj commented 8 years ago

Note: since this is functionally the same as googleapis/gax-python#103, I'll only make language-independent comments over there.

jmuk commented 8 years ago

committing to this PR as this behavior is already discussed in googleapis/gax-python#103