Closed euanlau closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
Merging #132 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 19 19
Lines 2029 2029
=======================================
Hits 2016 2016
Misses 13 13
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6bdac21...a6a4a69. Read the comment docs.
@euanlau are you able to sign the CLA so that we can take a look at this?
@jbolinger just signed it. thanks!
CLAs look good, thanks!
@euanlau looks good. Thanks for catching this!
any update on this?
@euanlau thanks for fixing this!
Google::Auth::Credentials initialization expects
scope
, notscopes
as an option.