googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Fix scope option #132

Closed euanlau closed 6 years ago

euanlau commented 6 years ago

Google::Auth::Credentials initialization expects scope, not scopes as an option.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
codecov-io commented 6 years ago

Codecov Report

Merging #132 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files          19       19           
  Lines        2029     2029           
=======================================
  Hits         2016     2016           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bdac21...a6a4a69. Read the comment docs.

jbolinger commented 6 years ago

@euanlau are you able to sign the CLA so that we can take a look at this?

euanlau commented 6 years ago

@jbolinger just signed it. thanks!

googlebot commented 6 years ago

CLAs look good, thanks!

jbolinger commented 6 years ago

@euanlau looks good. Thanks for catching this!

euanlau commented 6 years ago

any update on this?

jbolinger commented 6 years ago

@euanlau thanks for fixing this!