googleapis / gax-ruby

Google API Extensions for Ruby

https://rubygems.org/gems/google-gax

BSD 3-Clause "New" or "Revised" License

20 stars 22 forks source link

Update googleauth dependency #138

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Allow the dependency to use the 0.7.x releases.

jbolinger commented 5 years ago

@landrito do you know if this version was pinned for any reason?

@blowmage I assume that you've already tested this with the cloud apis?

landrito commented 5 years ago

I remember no reason why it was pinned so strictly. Sorry! LGTM assuming some hand tests show nothing breaks.

codecov-io commented 5 years ago

Codecov Report

Merging #138 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          19       19           
  Lines        2064     2064           
=======================================
  Hits         2049     2049           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d872071...f660b7f. Read the comment docs.

blowmage commented 5 years ago

@blowmage I assume that you've already tested this with the cloud apis?

Not yet. This PR is part of incorporating some new functionality released in the latest version of googleauth into the cloud gems.

blowmage commented 5 years ago

Ping

jbolinger commented 5 years ago

@blowmage have you been able to test it with this updated auth version?

blowmage commented 5 years ago

No, I have not. Isn't making the change and running this repo's existing CI sufficient?

jbolinger commented 5 years ago

That's sufficient to merge but I don't think the existing CI runs any real tests so I would like to verify before releasing it. Do you need one soon?

blowmage commented 5 years ago

I've tested this against google-cloud-ruby with googleauth 0.7.1 and everything works as expected.

blowmage commented 5 years ago

I noticed this PR was out of date. I have updated it to the latest master. Can someone take a look?

jbolinger commented 5 years ago

Thanks for verifying with google-cloud-ruby @blowmage! I'll merge it now.