search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Make Operation class type arguments optional #142

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

This PR changes the Google::Gax::Operation result_type and metadata_type arguments to be optional. This is a backwards compatible change.

blowmage commented 5 years ago

@jbolinger @quartzmo Thoughts?

codecov-io commented 5 years ago

Codecov Report

Merging #142 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   99.27%   99.27%   +<.01%     
==========================================
  Files          19       19              
  Lines        2058     2064       +6     
==========================================
+ Hits         2043     2049       +6     
  Misses         15       15
Impacted Files Coverage Δ
lib/google/gax/operation.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/operation_spec.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5cfd60...e96188c. Read the comment docs.

jbolinger commented 5 years ago

Relying on the registry to do the lookup is probably the common case, so adding the nil defaults seems like a good idea to me.