googleapis / gax-ruby

Google API Extensions for Ruby

BSD 3-Clause "New" or "Revised" License

20 stars 22 forks source link

Loosen googleauth dependency #143

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Loosen the googleauth dependency to allow future changes. The team supporting googleauth has committed to not change backwards compatibility before 0.10.0.

blowmage commented 5 years ago

@jbolinger @landrito Ping.

codecov[bot] commented 5 years ago

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          19       19           
  Lines        2064     2064           
=======================================
  Hits         2049     2049           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fe8dad...73d6e29. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          19       19           
  Lines        2064     2064           
=======================================
  Hits         2049     2049           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fe8dad...73d6e29. Read the comment docs.

blowmage commented 5 years ago

We were holding for this to be in the next release. AFAIK we are good to release.

jbolinger commented 5 years ago

Ok, I will release a new version shortly.