googleapis / gax-ruby

Google API Extensions for Ruby

https://rubygems.org/gems/google-gax

BSD 3-Clause "New" or "Revised" License

20 stars 22 forks source link

Fix retry_codes when empty #158

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

[fixes #71]

jbolinger commented 5 years ago

@blowmage do you know what's going on with the tests on 2.2?

blowmage commented 5 years ago

The latest version of protobuf dropped the pre-compiled file for 2.2

blowmage commented 5 years ago

@jbolinger Once #159 is approved I'll merge and rebase this PR to get the fix. Then this PR should pass CI.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (1.x@4031be3). Click here to learn what that means. The diff coverage is 100%.

@@          Coverage Diff           @@
##             1.x     #158   +/-   ##
======================================
  Coverage       ?   99.22%           
======================================
  Files          ?       19           
  Lines          ?     2070           
  Branches       ?        0           
======================================
  Hits           ?     2054           
  Misses         ?       16           
  Partials       ?        0

Impacted Files	Coverage Δ
spec/google/gax/api_callable_spec.rb	`97.81% <100%> (ø)`
lib/google/gax/settings.rb	`99.02% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4031be3...2b77396. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #158 into 1.x will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##              1.x     #158      +/-   ##
==========================================
+ Coverage   99.24%   99.24%   +<.01%     
==========================================
  Files          19       19              
  Lines        2122     2123       +1     
==========================================
+ Hits         2106     2107       +1     
  Misses         16       16

Impacted Files	Coverage Δ
spec/google/gax/api_callable_spec.rb	`97.81% <100%> (ø)`	:arrow_up:
lib/google/gax/settings.rb	`99.09% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4031be3...2b77396. Read the comment docs.