googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Remove RPC retry #160

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Retry will be restored with a different implementation in the future.

codecov[bot] commented 5 years ago

Codecov Report

Merging #160 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          15       15           
  Lines        1158     1158           
=======================================
  Hits         1148     1148           
  Misses         10       10
Impacted Files Coverage Δ
spec/google/gax/api_callable_spec.rb 98.02% <ø> (ø) :arrow_up:
spec/google/gax/settings_spec.rb 100% <ø> (ø) :arrow_up:
lib/google/gax/api_callable.rb 96.7% <100%> (ø) :arrow_up:
lib/google/gax/settings.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/operation_spec.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23e6085...d396a70. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #160 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          15       15           
  Lines        1158     1158           
=======================================
  Hits         1148     1148           
  Misses         10       10
Impacted Files Coverage Δ
spec/google/gax/api_callable_spec.rb 98.02% <ø> (ø) :arrow_up:
spec/google/gax/settings_spec.rb 100% <ø> (ø) :arrow_up:
lib/google/gax/api_callable.rb 96.7% <100%> (ø) :arrow_up:
lib/google/gax/settings.rb 100% <100%> (ø) :arrow_up:
spec/google/gax/operation_spec.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23e6085...d396a70. Read the comment docs.

blowmage commented 5 years ago

Oops, this was already submitted and merged in #157.