search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Remove PageDescriptor #162

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Wrapping pagination responses in PagedEnumerable will happen in the GAPIC client instead of in GAX. Remove page_token from CallOptions.

codecov[bot] commented 5 years ago

Codecov Report

Merging #162 into master will decrease coverage by 2.89%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #162     +/-   ##
=========================================
- Coverage   98.66%   95.77%   -2.9%     
=========================================
  Files          14       14             
  Lines        1127     1066     -61     
=========================================
- Hits         1112     1021     -91     
- Misses         15       45     +30
Impacted Files Coverage Δ
spec/google/gax/api_callable_spec.rb 97.14% <ø> (-0.89%) :arrow_down:
lib/google/gax/api_callable.rb 61.17% <100%> (-35.53%) :arrow_down:
lib/google/gax/settings.rb 86.48% <100%> (-2.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2230377...5c703fb. Read the comment docs.