search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Merge kwargs and metadata in CallOptions #163

Closed jbolinger closed 5 years ago

jbolinger commented 5 years ago

kwargs was renamed to metadata since it was used exclusively for metadata, but the existing parameter was kept around to avoid a breaking change. kwargs should be dropped.

blowmage commented 5 years ago

Agreed. CallOptions is tied pretty closely to CallSettings, and #164 makes some changes to CallOptions so CallSettings can be removed. It also drops kwargs from CallOptions. If that PR is accepted I think it may satisfy this issue.