search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Remove CallSettings #164

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

[closes #148]

codecov[bot] commented 5 years ago

Codecov Report

Merging #164 into master will increase coverage by 0.36%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   97.91%   98.28%   +0.36%     
==========================================
  Files          18       18              
  Lines        1201     1165      -36     
==========================================
- Hits         1176     1145      -31     
+ Misses         25       20       -5
Impacted Files Coverage Δ
lib/google/gax/api_callable.rb 96% <100%> (-0.97%) :arrow_down:
lib/google/gax/settings.rb 100% <100%> (+13.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbfd613...d51600d. Read the comment docs.

blowmage commented 5 years ago

settings is still mentioned in the create_api_call docs.

Good catch. Updated the docs

blowmage commented 5 years ago

@jbolinger @quartzmo This PR is ready to be reviewed now.

blowmage commented 5 years ago

It would admittedly, make this an even more drastic change and shift some responsibility to the generator.

This is where I am leaning. The more we can put in the generator, the less that the runtime has to manage. The PathTemplate class is a great example. We can parse the resource path templates in the generator and output a simple ruby module that has no other runtime dependencies. I think there are opportunities for more changes like that across the microgenerator and gax 2.0