blowmage commented 5 years ago

Use a more familiar convention for creating a Gax Stub object. Also, simplify the credentials arguments and have the Gax wrapper sort the various types of credentials values out.

The GAPIC generator side of this change is in: googleapis/gapic-generator-ruby#116

codecov[bot] commented 5 years ago

Codecov Report

Merging #180 into master will increase coverage by 0.36%. The diff coverage is 98.97%.

@@           Coverage Diff            @@
##           master   #180      +/-   ##
========================================
+ Coverage   98.63%    99%   +0.36%     
========================================
  Files          27     29       +2     
  Lines        1538   1502      -36     
========================================
- Hits         1517   1487      -30     
+ Misses         21     15       -6

Impacted Files	Coverage Δ
lib/google/gax/api_call.rb	`100% <ø> (ø)`	:arrow_up:
test/google/gax/grpc/stub_test.rb	`100% <100%> (ø)`
.../gax/grpc/deserialize_error_status_details_test.rb	`100% <100%> (ø)`
lib/google/gax/grpc.rb	`100% <100%> (+6.12%)`	:arrow_up:
lib/google/gax/grpc/stub.rb	`95.65% <95.65%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15ebffb...70f9407. Read the comment docs.

blowmage commented 5 years ago

I pushed the create PR button before this was ready to be reviewed. PTAL now.

jbolinger commented 5 years ago

@blowmage I think you still need to update one of the tests to use the new method signature.

blowmage commented 5 years ago

@jbolinger I was working off some old commits. Updated the branch to the commit with tests. CI is passing now. PTAL.

googleapis / gax-ruby

Refactor Google::Gax::Stub::new #180

Codecov Report