search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Refactor Proto.coerce #184

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

This used to be a class method Gax.to_proto, but the name had issues. First, it was not a conversion method on an object, but on a class. The to_* methods are usually used to convert from one object to another object. Renaming to coerce is more accurate.

codecov[bot] commented 5 years ago

Codecov Report

Merging #184 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage      99%   98.99%   -0.01%     
==========================================
  Files          29       30       +1     
  Lines        1502     1496       -6     
==========================================
- Hits         1487     1481       -6     
  Misses         15       15
Impacted Files Coverage Δ
test/google/gax/protobuf/time_test.rb 100% <100%> (ø)
test/google/gax/protobuf/coerce_test.rb 100% <100%> (ø)
lib/google/gax/protobuf.rb 100% <100%> (ø)
lib/google/gax.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24b1332...670f01d. Read the comment docs.