search

googleapis / gax-ruby

Google API Extensions for Ruby
https://rubygems.org/gems/google-gax
BSD 3-Clause "New" or "Revised" License
20 stars 22 forks source link

Operation Updates #189

Closed blowmage closed 5 years ago

blowmage commented 5 years ago

Use the new Operations class from gapic generator. Update the constructor to use named arguments for optional arguments (result_type and metadata_type).

codecov[bot] commented 5 years ago

Codecov Report

Merging #189 into master will decrease coverage by 11.99%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #189    +/-   ##
========================================
- Coverage   98.81%   86.81%   -12%     
========================================
  Files          31       31            
  Lines        1517     1517            
========================================
- Hits         1499     1317   -182     
- Misses         18      200   +182
Impacted Files Coverage Δ
lib/google/gax/operation.rb 57.14% <100%> (-42.86%) :arrow_down:
lib/google/gax/operation/retry_policy.rb 48.48% <0%> (-51.52%) :arrow_down:
test/google/gax/operation_test.rb 52.24% <0%> (-47.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f58b781...f8f1dfc. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #189 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   98.83%   98.83%   +<.01%     
==========================================
  Files          32       32              
  Lines        1542     1547       +5     
==========================================
+ Hits         1524     1529       +5     
  Misses         18       18
Impacted Files Coverage Δ
lib/google/gax/operation.rb 100% <100%> (ø) :arrow_up:
lib/google/gax/paged_enumerable.rb 96.1% <100%> (ø) :arrow_up:
test/google/gax/operation_test.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9ff3bc...fb93d27. Read the comment docs.

blowmage commented 5 years ago

This PR cannot be merged until #190 is merged.

blowmage commented 5 years ago

The google-style update is messing with the build. I'm gonna fix it in this PR.